DPS310 bar gizmo & fix #79 #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EnzoPB , looks very good already! Just a couple quick comments: Maybe split this in two PRs, makes it easier to review. Have a look at src/rdr/rdr.cpp which uses gizmos with a static create() method to make it possible to return a "fail" on gizmo creation. |
|
I'll finish that on monday, I also want to test it on another board with another MCU. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the DPS310 barometric sensor gizmo (taken from Infineon/arduino-xensiv-dps3xx), and fixes issue #79 where IMU interrupts where not getting triggered.
Now right after
attachInterrupt,HAL_NVIC_SetPriorityis called to set the interrupt priority to the maximum allowed while still allowing FreeRTOS API calls inside the ISR.NOTE: this MR is still a draft, see src/bar/BarGizmoDPS310.h line 20.